Fix/#225 오픈 프로필 url 없으면 exception 발생하도록 수정 #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
java-saeng
added
버그
hyeonjerry
approved these changes
Aug 7, 2023
| @@ -29,6 +30,7 @@ public class Member extends BaseEntity { | |||
| @Column(nullable = false) | |||
| private String description; | |||
| @Column | |||
| @Getter(value = AccessLevel.PRIVATE) | |||
There was a problem hiding this comment.
혹시 AccessLevel을 PRIVATE으로 설정하고 밑에 구현하신 이유가 있으신가요?
밑에 직접 getter를 구현하면 자동으로 override가 되지 않나요?
amaran-th
approved these changes
Aug 7, 2023
hong-sile
reviewed
Aug 7, 2023
| @@ -108,7 +113,7 @@ private String getAccessToken() { | |||
| try { | |||
| final GoogleCredentials googleCredentials = GoogleCredentials | |||
| .fromStream(new ClassPathResource(firebaseConfigPath).getInputStream()) | |||
| .createScoped(List.of("https://www.googleapis.com/auth/cloud-platform")); | |||
| .createScoped(List.of(GOOGLE_AUTH_URL)); | |||
|
|
|||
| googleCredentials.refreshIfExpired(); | |||
There was a problem hiding this comment.
ControllerAdvice가 로그를 남기고 있으니까, log.error를 굳이 찍을 필요가 없지 않나요?
| @@ -84,15 +86,18 @@ private String makeMessage(final String targetToken, final Notification notifica | |||
| final Member sender = memberRepository.findById(senderId) | |||
| .orElseThrow(() -> new MemberException(MemberExceptionType.NOT_FOUND_MEMBER)); | |||
|
|
|||
| final String openProfileUrl = sender.getOptionalOpenProfileUrl() | |||
There was a problem hiding this comment.
request changed가 여기밖에 없어서, 여기 남깁니다.
78번째 라인의 log.error를 찍는 부분이 있는데,
이 부분에 다른 CustomException을 만드는 게 좋지 않을까요?
- 예상하지 못한 Exception에 대한 handler 생성 #225
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
📝작업 내용
알림 보낼 사람의 오픈 프로필 URL이 없으면 알림을 보낼 수 없게 Exception 추가
예상 소요 시간 및 실제 소요 시간
1시간 / 1시간