Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FE] feat : 리뷰 작성 내용 확인 에서 쓰지 않은 서술형에서 답변을 작성하지 않았다는 문구 띄어주기 #466

Merged
merged 3 commits into from
Aug 20, 2024
Merged

[FE] feat : 리뷰 작성 내용 확인 에서 쓰지 않은 서술형에서 답변을 작성하지 않았다는 문구 띄어주기 #466

merged 3 commits into from
Aug 20, 2024

Conversation

BadaHertz52
Copy link
Contributor

🚀 어떤 기능을 구현했나요 ?

  • 리뷰 작성 내용 확인 에서 쓰지 않은 서술형에서 답변을 작성하지 않았다는 문구 띄어줬어요.

🔥 어떻게 해결했나요 ?

  • AnswerListRecheckModal을 ReviewWritingCardFormPage 의 components 폴더로 이동시켰어요.
  • LongReviewItem의 font-weight 삭제했어요.
  • 답변이 없는 서술형의 경우 '작성한 답변이 없어요'라는 문구를 띄워주도록 수정했어요.
    image

📝 어떤 부분에 집중해서 리뷰해야 할까요?

  • 위의 화면에 '작성한 답변이 없어요' 디자인이 괜찮은지 봐주세요.

📚 참고 자료, 할 말

  • 쌓여가는 pr

@BadaHertz52 BadaHertz52 added this to the 4차 스프린트: 최종 milestone Aug 20, 2024
@BadaHertz52 BadaHertz52 self-assigned this Aug 20, 2024
chysis
chysis approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@chysis chysis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

더 좋은 사용자 경험🔥

ImxYJL
ImxYJL approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@ImxYJL ImxYJL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 은근 신경쓰였는데 보강됐다니 좋아요~~~

soosoo22
soosoo22 approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@soosoo22 soosoo22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확실히 답변이 작성되지 않았다는 문구가 추가되니 좋은 것 같아요! 수고했어요 바다!

@BadaHertz52 BadaHertz52 merged commit 96d8e2b into develop Aug 20, 2024
5 checks passed
@donghoony donghoony deleted the fe/feat/461-review_writing_confirm branch August 23, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ImxYJL ImxYJL ImxYJL approved these changes

@soosoo22 soosoo22 soosoo22 approved these changes

@chysis chysis chysis approved these changes

Assignees

@BadaHertz52 BadaHertz52

Labels
🍀 FE 🍰 초간단 🎨 디자인 🐛 버그
Projects
2024-review-me
Status: Done
Milestone
4차 스프린트: 최종
4 participants
@BadaHertz52 @chysis @soosoo22 @ImxYJL