Add workbench.build experimental API #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonnyp
commented
Oct 19, 2023
| @@ -80,6 +81,10 @@ export default function Internal({ | |||
| dropdown_preview_align.selected = 0; | |||
| preview(object); | |||
| }, | |||
| build(params) { | |||
There was a problem hiding this comment.
I wonder if we should do this instead
Suggested change
| build(params) { | |
| build(interface, params) { |
and use it like so:
Suggested change
| build(params) { | |
| workbench.build(workbench.interface, params); |
It's a bit repetitive, but it's closer to whatever "standard" API we will get.
There was a problem hiding this comment.
Sorry, what would workbench.interface resolve to?
There was a problem hiding this comment.
Ah, for the primary demo interface?
There was a problem hiding this comment.
for the code in the UI panel
andyholmes
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #667
Makes Workbench support signal handlers and closures for Gtk interface.
It uses https://github.com/sonnyp/troll#build