Support analysis / types with Rust Analyzer #883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #881 It still takes a bit until diagnostics arrive, but this way error messages from `cargo` are included as well.
sonnyp
reviewed
Feb 15, 2024
I shouldn't be necessary to do anything special, but I also noticed that it doesn't always work on my machine. Before merging, we should also look out if this PR introduces regressions. If yes, maybe we just merge a subset of it. |
Before this change, Workbench installed via Flatpak was not able to run Vala demos that required Shumate, Libportal or Libspelling because their header files were removed by the cleanup process. The versions of Workbench that are run from Builder or flatpak-vscode can actually compile and execute this demos because they don't do any clean-up, and therefore none of the header files are deleted, which is probably why this issue went unnoticed for quite some time even when porting the affected demos to Vala. In order to test this changes and compare them with the current version of Workbench, it is necessary to export a bundle and install it, so the cleanup process is actually done. Closes #885
`libxmljs` one of our nodejs dependencies requires a C++ compiler
Co-authored-by: Sonny Piers <[email protected]> Co-authored-by: Marco Capypara Köpcke <[email protected]>
Co-authored-by: Sonny Piers <[email protected]>
This commit adds my name to the contributor list for #857 Thanks so much for the patience and help I received from you @sonnyp @theCapypara
We only support English
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #881
It still takes a bit until diagnostics arrive, but this way error messages from
cargoare included as well.Also moves the target dir to a common place, similar to how we do it when we compile Rust.