Port 'Database' demo to Python #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for pointing that out, I had forgotten to remove the field. Done in f53216e |
|
@theCapypara With the removal of the id search entry by @sonnyp everything should work as expected. |
|
Thanks! I'll have a look on the weekend! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The demo works the same as the Javascript version, I think.
However in the original Database demo #200 by @BharatAtbrat the search by id worked and it does not currently (neither in Javascript nor in Python). This may be due to the "further simplifications" 909c833 where
findByIdgot nuked.Please tell me if that should be made working again.