fix(pubsub): compute McuMessage wrapper size without throwing error #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sri9311
approved these changes
Jan 13, 2025
fouge
force-pushed
the
fouge/compute-mcu-message-wrapper-size
branch
from
a676518 to
e265652
Compare
because we want to minimize memory used to store messages to send, we compute the number of bytes taken to wrap the payload to send into an McuMessage. The number of bytes is guessed thanks to the McuMessage max size and all the payloads max sizes which are all known at compile time. In case the biggest payload among the 4 available changes, the computation needs to change: we now use the max of all 4 so that we don't have to throw an error in case the biggest payload changes. Signed-off-by: Cyril Fougeray <[email protected]>
fouge
force-pushed
the
fouge/compute-mcu-message-wrapper-size
branch
from
e265652 to
59677e3
Compare
|
@sri9311 I moved the computation / declaration of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because we want to minimize memory used to store messages to send, we compute the number of bytes taken to wrap the payload to send into an McuMessage.
The number of bytes is guessed thanks to the McuMessage max size and all
the payloads max sizes which are all known at compile time.
In case the biggest payload among the 4 available changes, the computation needs to change: we now use the max of all 4 so that we don't have to throw an error in case the biggest payload changes.