Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release versions #10

Open
michaelwitting opened this issue Aug 25, 2019 · 1 comment
Open

Release versions #10

michaelwitting opened this issue Aug 25, 2019 · 1 comment
Labels
discussion Discussions about model development
Milestone

Comments

@michaelwitting
Copy link
Collaborator

Hi,

I suggest that we add folder called release_versions beside our model_versions folder to store ready to use versions of the model. We also have to come up with version numbering and a system for the numbering.
I suggest that the next stable version will become WormJam 1.0, after we found the problems with ATP production. Version numbers would increase in the following manner 1.X.Y. Y increases if minor changes like metabolite structure curation etc was performed. X increases if some bigger changes have been made, e.g. a new set of reactions or a new pathway has been added. A new full version would be for example expansion of compartments or other rather major changes.

Let me know your thoughts.

Michael

@JakeHattwell
Copy link
Collaborator

I like the idea of versioning.
Github does have an inbuilt release system, in which we can make a "public release", such as version 1.0.0.
We don't have to use a different folder for it, however, as it will be available from the release history section of the github page.

As for the versioning, I'd advocate using the Semantic Versioning system
https://semver.org/

@JakeHattwell JakeHattwell added the discussion Discussions about model development label Aug 26, 2019
@michaelwitting michaelwitting added this to the WormJam v1.0 milestone Sep 5, 2019
JakeHattwell pushed a commit that referenced this issue Mar 26, 2021
* WIP: Adding configuration script

 - Added PyYAML to requirements
 - Created configuration.py

* WIP: Add validation for db_table prompt

 - This change ensures the value entered for db_table can be converted to a boolean
 - The config now saves db_table as boolean
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Discussions about model development
Projects
None yet
Development

No branches or pull requests

2 participants