Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant grouping in Gene Associations #13

Open
JakeHattwell opened this issue Sep 5, 2019 · 1 comment
Open

Redundant grouping in Gene Associations #13

JakeHattwell opened this issue Sep 5, 2019 · 1 comment
Labels
discussion Discussions about model development
Milestone

Comments

@JakeHattwell
Copy link
Collaborator

JakeHattwell commented Sep 5, 2019

Whilst I'm working on the CI pipeline for the WJ model, I've noticed we have a lot of redundant parentheses in our gene associations. Some examples are below

R_RC02241
((WBGene00020264 or WBGene00022646 or WBGene00044631) or (WBGene00010339 or WBGene00011543) or (WBGene00016934 or WBGene00007446 or WBGene00013995)) or WBGene00017888

R_rnasynth_m
((WBGene00009658 or WBGene00011791 or WBGene00012528) and WBGene00001596 and WBGene00014115) and (WBGene00012999 and WBGene00008781 and WBGene00000123 and WBGene00016140 and WBGene00004411 and WBGene00017300 and WBGene00013680)

Whilst this makes no difference to the actual way genes are handled, it is potentially something we should tidy up at some point.

@JakeHattwell JakeHattwell added the discussion Discussions about model development label Sep 5, 2019
@michaelwitting
Copy link
Collaborator

I totally agree... I guest most of it is coming from the merging process. We should make clear rules for the future how this is used. I prefer to have the AND only for multiprotein complexes and not for lumped/nested reactions. If their are alternative multimers we can have parentheses llike (A AND B) OR (A AND C).

@michaelwitting michaelwitting added this to the WormJam v1.0 milestone Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Discussions about model development
Projects
None yet
Development

No branches or pull requests

2 participants