-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Highlight matching characters #54
Comments
I am not in favour of this proposal simply because it's not the job of this library to handle results rendering. |
@ralf57 I agree that this lib shouldn't handle rendering and this request doesn't change that. It allows for mapping over results with relevant information. |
Something I could do which wouldn't change much in the code I think; would be to return the indexes of the matches somehow. As I already use the indexes to search for matches.
Something along those lines, probably won't be exactly that. I'll have to figure a nicer way, but that way you can manually map the results. |
Hey, |
Is it underway? |
I think that it would be great if we could highlight characters that triggered the match
search: somestring
result:
foosomestringbar
foosomethingStringbar
API could be something like this
What do you think about such feature? I really miss something like this.
The text was updated successfully, but these errors were encountered: