Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SQLite tests #494

Open
4 of 8 tasks
woylie opened this issue Sep 11, 2024 · 0 comments
Open
4 of 8 tasks

Fix SQLite tests #494

woylie opened this issue Sep 11, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@woylie
Copy link
Owner

woylie commented Sep 11, 2024

Thanks to @martosaur, we can run tests on SQLite with mix test.sqlite now. A bunch of tests are failing. We can track the progress in this issue.

  • ilike: Not supported by SQLite.
  • like tests: Is case-insensitive in SQLite, which causes tests to fail.
  • offset requires limit in SQLite. For unlimited result set, use limit -1.
  • empty/not_empty operators
  • character escape in like queries: Flop escapes %, _, and \\ in filter strings for like/ilike operators. SQLite requires to specify escape characters with ESCAPE (see https://www.sqlitetutor.com/escape/).
  • tests with postgres composite types can be skipped

After fixing everything

  • run mix test.all in tests job of GH actions workflow
  • change mix coveralls.json.all to run tests on all adapters
@woylie woylie added the enhancement New feature or request label Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant