Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation notices on PHP8+ about optional parameters before mandatory ones #148

Open
MathieuLamiot opened this issue Oct 2, 2024 · 0 comments

Comments

@MathieuLamiot
Copy link
Collaborator

Context
https://wp-media.slack.com/archives/C07HCD19B/p1727784189218359
https://secure.helpscout.net/conversation/2720613961/514890

The following deprecation notices are reported on PHP8+:

Deprecated: Optional parameter $search declared before required parameter $table is implicitly treated as a required parameter in /home/nglcom/public_html/negoluz.nz/wp-content/plugins/search-and-replace/inc/Database/Exporter.php on line 295

Deprecated: Optional parameter $replace declared before required parameter $table is implicitly treated as a required parameter in /home/nglcom/public_html/negoluz.nz/wp-content/plugins/search-and-replace/inc/Database/Exporter.php on line 295

There is no impact on the behavior, apart from adding deprecation notices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant