Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wpilibjExamples - SysId example does not reference Shooter subsystem in button bindings #7255

Closed
mrokitka opened this issue Oct 22, 2024 · 1 comment · Fixed by #7392
Closed

wpilibjExamples - SysId example does not reference Shooter subsystem in button bindings #7255

mrokitka opened this issue Oct 22, 2024 · 1 comment · Fixed by #7392
Labels
component: examples good first issue Good for newcomers.

Comments

@mrokitka
Copy link

Describe the bug
The SysIdRoutineBot.java class in wpilibjExamples never binds the SysId tests for the Shooter to the controller. The example erroneously binds the drivetrain tests twice (once in the right bumper set of button bindings and again in the left bumper set of bindings).

Expected behavior
The example should be updated to something like this:

m_driverController
    .a()
    .and(m_driverController.leftBumper())
    .whileTrue(m_shooter.sysIdQuasistatic(SysIdRoutine.Direction.kForward));
m_driverController
    .b()
    .and(m_driverController.leftBumper())
    .whileTrue(m_shooter.sysIdQuasistatic(SysIdRoutine.Direction.kReverse));
m_driverController
    .x()
    .and(m_driverController.leftBumper())
    .whileTrue(m_shooter.sysIdDynamic(SysIdRoutine.Direction.kForward));
m_driverController
    .y()
    .and(m_driverController.leftBumper())
    .whileTrue(m_shooter.sysIdDynamic(SysIdRoutine.Direction.kReverse));

Additional context
Add any other context about the problem here.
@KangarooKoala
Copy link
Contributor

I can't label this as such, but this would be a good first issue. Fortunately, the C++ version (https://github.com/wpilibsuite/allwpilib/blob/v2025.1.1-beta-1/wpilibcExamples/src/main/cpp/examples/SysId/cpp/SysIdRoutineBot.cpp) is correct, so only Java would be necessary.

@Advay17 Advay17 mentioned this issue Nov 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: examples good first issue Good for newcomers.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SysId Example References Shooter Subsystem Advay17/allwpilib
3 participants
@rzblue @mrokitka @KangarooKoala