Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a trigger factory for isConnected on CommandGenericHID #7416

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Add a trigger factory for isConnected on CommandGenericHID #7416

wants to merge 6 commits into from
+22 −0

Conversation

shueja
Copy link
Contributor

@shueja shueja commented Nov 21, 2024 •
edited
Loading

If the naming is acceptable, I'll do C++/Python.

@shueja shueja requested a review from a team as a code owner November 21, 2024 08:03
@github-actions GitHub Actions
Copy link
Contributor

This PR modifies commands. Please open a corresponding PR in Python Commands and include a link to this PR.

@shueja
Copy link
Contributor Author

shueja commented Nov 21, 2024

/format

@shueja
Copy link
Contributor Author

shueja commented Nov 21, 2024

/format

KangarooKoala
KangarooKoala reviewed Nov 22, 2024
View reviewed changes
Copy link
Contributor

@KangarooKoala KangarooKoala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming seems fine to me, you could either go ahead with C++ and Python right away or wait until more people weigh in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KangarooKoala KangarooKoala KangarooKoala left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shueja @KangarooKoala