Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blake2b argument checking #2

Open
bpvgoncalves opened this issue Jan 29, 2023 · 0 comments
Open

Blake2b argument checking #2

bpvgoncalves opened this issue Jan 29, 2023 · 0 comments

Comments

@bpvgoncalves
Copy link

Hello.
I've been looking at this package for the last couple of weeks because I wanted to use argon2 as a kdf for a project of mine and used your version as the base for it.
In the meantime I've found an issue with the 'key' argument type checking on blake2b R function: instead of checking the 'key' for types string and raw, the 'x' (input to be hashed) is checked twice.

I have this fixed on my fork (branch fix-blake2b) and I'm more than happy to open a PR if you so wish.
Also happy to contribute back the developments I did over your code if you find them useful to include in the package.

Best Regards.
Bruno

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant