Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prune redundant posts/render.go #10

Open
wants to merge 2 commits into
base: version-2
Choose a base branch
from

Conversation

eddsalkield
Copy link
Contributor

None of the functions in posts/render.go are ever used anywhere. By pruning this dead code, we lose the dependencies on github.com/microcosm-cc/bluemonday and github.com/writeas/saturday, aiding the packaging process.

Fixes issue #9.

@eddsalkield
Copy link
Contributor Author

I initially introduced more commits than I intended in this PR. I've cleaned it up with a force push, and merged the branches to remove conflicts.

@thebaer thebaer linked an issue Sep 24, 2020 that may be closed by this pull request
@thebaer thebaer changed the base branch from master to version-2 September 24, 2020 15:00
@thebaer
Copy link
Member

thebaer commented Sep 27, 2020

Thanks for submitting this! While WF doesn't need these funcs, we do have some small proprietary web apps that rely on it right now. That might change in the future, but for now, we'll need to keep them in the library.

Since this is a breaking change, we'll slate this for v2.0 of the library and then we'll need to maintain a parallel v1.x track going forward, for apps that need the Markdown funcs. I've created a new branch for that, which we'll leave open in case any other changes are needed for it.

@eddsalkield
Copy link
Contributor Author

That's great, thanks.

There might yet be more changes I'd like to make for code cleanup/packaging reasons, but once they're done can we consider cutting a 2.0.0 release for versioning reasons?

@thebaer
Copy link
Member

thebaer commented Oct 3, 2020

Yep, that'll work great -- and then we'll just want to update WriteFreely to use v2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate markdown rendering with writefreely
2 participants