-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for email domain based organization discovery during self-registration. #51
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #51 +/- ##
============================================
+ Coverage 59.63% 62.26% +2.62%
+ Complexity 178 163 -15
============================================
Files 4 4
Lines 934 946 +12
Branches 120 125 +5
============================================
+ Hits 557 589 +32
+ Misses 319 296 -23
- Partials 58 61 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
.../carbon/identity/application/authenticator/organization/login/OrganizationAuthenticator.java
Show resolved
Hide resolved
.../carbon/identity/application/authenticator/organization/login/OrganizationAuthenticator.java
Show resolved
Hide resolved
64268d0
to
3b29d0c
Compare
3b29d0c
to
409aa2f
Compare
PR builder started |
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12085224255
Purpose
This PR improves the organization SSO authenticator to allow the use of existing organization discovery capabilities during the self-registration flow as well.
Two new parameters are used to enable this capability
isSelfRegistration
: This is used in the organization discovery page to conditionally render organization name based organization discovery content. (organization name based discovery capability is not provided in the self-registration flow)discoveredUsername
: This is resolved from the provided username in domain discovery page. Used to auto complete the email in the self-registration pageRelated issue