Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for email domain based organization discovery during self-registration. #51

Merged
merged 2 commits into from
Nov 30, 2024

Conversation

Yasasr1
Copy link
Contributor

@Yasasr1 Yasasr1 commented Nov 4, 2024

Purpose

This PR improves the organization SSO authenticator to allow the use of existing organization discovery capabilities during the self-registration flow as well.

Two new parameters are used to enable this capability

  • isSelfRegistration: This is used in the organization discovery page to conditionally render organization name based organization discovery content. (organization name based discovery capability is not provided in the self-registration flow)
  • discoveredUsername: This is resolved from the provided username in domain discovery page. Used to auto complete the email in the self-registration page

Related issue

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 62.26%. Comparing base (4c60673) to head (409aa2f).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
.../organization/login/OrganizationAuthenticator.java 83.33% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #51      +/-   ##
============================================
+ Coverage     59.63%   62.26%   +2.62%     
+ Complexity      178      163      -15     
============================================
  Files             4        4              
  Lines           934      946      +12     
  Branches        120      125       +5     
============================================
+ Hits            557      589      +32     
+ Misses          319      296      -23     
- Partials         58       61       +3     
Flag Coverage Δ
unit 45.58% <83.33%> (+8.47%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Yasasr1 Yasasr1 force-pushed the org-discovery-self-reg branch from 64268d0 to 3b29d0c Compare November 28, 2024 04:46
@Yasasr1 Yasasr1 force-pushed the org-discovery-self-reg branch from 3b29d0c to 409aa2f Compare November 28, 2024 04:48
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12085224255

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12085224255
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12085224255

@Yasasr1 Yasasr1 merged commit a8355df into wso2-extensions:main Nov 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants