Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GraalJS support for conditional authentication functions #152

Merged
merged 18 commits into from
May 26, 2024
Merged

Add GraalJS support for conditional authentication functions #152

merged 18 commits into from
May 26, 2024

Conversation

shanggeeth
Copy link
Contributor

@shanggeeth shanggeeth commented Jan 9, 2024 •
edited by janakamarasena
Loading

Purpose

  • Introduce GraalJS proxy objects.
  • Add wrapper factory for GraalJS proxy objects.
  • Modify adaptive funtions to support GraalJs Script engine execution
  • Add unit tests for GraalJs based script engine

Depends on:

@shanggeeth shanggeeth mentioned this pull request Feb 7, 2024
Merged
@shanggeeth shanggeeth changed the title [WIP] Add GraalJS support for conditional authentication functions Add GraalJS support for conditional authentication functions Feb 8, 2024
shanggeeth
shanggeeth commented Feb 26, 2024
View reviewed changes
pom.xml Outdated Show resolved Hide resolved
@shanggeeth shanggeeth force-pushed the graalvm branch 2 times, most recently from 4813d39 to fa5fbbe Compare May 19, 2024 16:33
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/9149111403

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/9149111403
Status: failure

@shanggeeth shanggeeth mentioned this pull request May 20, 2024
Merged
@shanggeeth
Copy link
Contributor Author

Unit test case failures since the PR depends on

Product build is locally successful with

Screenshot 2024-05-20 at 17 43 59

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/9161311191

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/9161311191
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/9168338845

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/9168338845
Status: failure

shanggeeth added 2 commits May 22, 2024 17:21
@shanggeeth
Add GraalJS support for conditional authentication functions.
00c1fd7 
* Introduce GraalJS proxy objects.
* Add wrapper factory for GraalJS proxy objects.
@shanggeeth
Fix bugs related to bound host functions
180a8de 
* GraalJS cannot convert proxy objects to native JAVA objects
* Error when executing function ReferenceError: getCookieValue is not defined
* Unsupported operation identifier 'addCookie'
* Async processes are not getting executed
shanggeeth added 15 commits May 22, 2024 17:21
@shanggeeth
Fix bugs related to bound host functions
851d912 
* Fix GetUserWithClaimValues
* Fix getAuthenticatedApplications
* Add hasMember methods to Proxy objects
* Add support for JsGraalApplication
* Fix UserStoreFunctions to support GraalJs
@shanggeeth
Add required import packages to support GraalJs based adaptive authen…
1656ed0 
…tication script engine
@shanggeeth
Fix minor bug in JsWrapperFactoryProvider logic
8e71e5b
@shanggeeth
Fix PublishToAnalyticsFunctionImpl bug due to graalVM's single thread…
139b2e6 
… restriction
@shanggeeth
Modify unit tests to test for both nashorn and graaljs script engines.
98e3380
@shanggeeth
Fix install issue in conditional authentication functions server feature
aea1041
@shanggeeth
Use @HostAccess.Export to export conditional authentication functions…
a3e6496 
… implementations.
@shanggeeth
Address review comments
56f5e2c
@shanggeeth
Revert JsBaseObjects usage
37eb0bb
@shanggeeth
Add new functional interfaces for modified functions
f86922f
@shanggeeth
Add changes due to new generic interfaces
74cbb9c
@shanggeeth
Fix failures due to new changes
10a8bc7
@shanggeeth
Support FilterAuthenticatorsFunction in GraalJS
1e64894
@shanggeeth
Bump framework version
b9d18f0
@shanggeeth
Add graaljs support for new user password migration functions
3ce5ece
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/9225922996

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/9225922996
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes May 24, 2024
View reviewed changes
Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/9225922996

@shanggeeth
Apply suggestions from code review
9fb7673 
Co-authored-by: Inthirakumaaran <[email protected]>
@shanggeeth shanggeeth merged commit 37f66b6 into wso2-extensions:master May 26, 2024
2 checks passed
@shanggeeth shanggeeth mentioned this pull request Sep 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenkins-is-staging jenkins-is-staging jenkins-is-staging approved these changes

@ZiyamSanthosh ZiyamSanthosh ZiyamSanthosh approved these changes

@inthirakumaaran inthirakumaaran Awaiting requested review from inthirakumaaran

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shanggeeth @jenkins-is-staging @inthirakumaaran @ZiyamSanthosh