Add AuthorizationCodeValidityPeriod config #1351
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mefarazath
reviewed
Apr 9, 2020
components/org.wso2.carbon.identity.oauth.ui/src/main/resources/web/oauth/edit.jsp
Outdated
Show resolved
Hide resolved
mefarazath
reviewed
Apr 9, 2020
...o2.carbon.identity.oauth/src/main/java/org/wso2/carbon/identity/oauth/OAuthAdminService.java
Show resolved
Hide resolved
mefarazath
reviewed
Apr 9, 2020
...wso2.carbon.identity.oauth/src/main/java/org/wso2/carbon/identity/oauth/dao/OAuthAppDAO.java
Outdated
Show resolved
Hide resolved
mefarazath
reviewed
Apr 9, 2020
...arbon.identity.oauth/src/main/java/org/wso2/carbon/identity/oauth/OAuthAdminServiceImpl.java
Show resolved
Hide resolved
ivantha
requested review from
aaujayasena,
Buddhimah,
denuwanthi,
dewniMW,
emswbandara and
janakamarasena
as code owners
denuwanthi
reviewed
Apr 10, 2020
components/org.wso2.carbon.identity.oauth.ui/src/main/resources/web/oauth/add.jsp
Show resolved
Hide resolved
denuwanthi
reviewed
Apr 10, 2020
...arbon.identity.oauth/src/main/java/org/wso2/carbon/identity/oauth/OAuthAdminServiceImpl.java
Show resolved
Hide resolved
mefarazath
reviewed
Apr 10, 2020
...wso2.carbon.identity.oauth/src/main/java/org/wso2/carbon/identity/oauth/dao/OAuthAppDAO.java
Outdated
Show resolved
Hide resolved
dewniMW
reviewed
Apr 15, 2020
...wso2.carbon.identity.oauth/src/main/java/org/wso2/carbon/identity/oauth/dao/OAuthAppDAO.java
Outdated
Show resolved
Hide resolved
dewniMW
reviewed
Apr 15, 2020
....wso2.carbon.identity.oauth/src/main/java/org/wso2/carbon/identity/oauth/dao/OAuthAppDO.java
Show resolved
Hide resolved
mefarazath
reviewed
Apr 15, 2020
...arbon.identity.oauth/src/main/java/org/wso2/carbon/identity/oauth/OAuthAdminServiceImpl.java
Outdated
Show resolved
Hide resolved
mefarazath
approved these changes
Apr 15, 2020
mefarazath
approved these changes
Apr 15, 2020
denuwanthi
approved these changes
Apr 16, 2020
|
Closing this as AuthorizationCodeValidityPeriod should not be changed at the app level. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add AuthorizationCodeValidityPeriod configuration to be set at the app level.
Closes #1352, wso2/product-is#8098, wso2/product-is#8099
Part of wso2/product-is#8096