Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude username in password grant error message using OAuth config #2644

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BiyonFernando
Copy link

Purpose

Approach

  • The below config has to add to deployment.toml to exclude username from error response in password grant token genration.
    [oauth]
    exclude_username_in_password_grant_error_message = true
  • If the config is not added original behaviour will preserve.

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 56.53%. Comparing base (654bc26) to head (7f869f2).
Report is 14 commits behind head on master.

Files with missing lines Patch % Lines
...th2/token/handlers/grant/PasswordGrantHandler.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2644      +/-   ##
============================================
+ Coverage     56.44%   56.53%   +0.09%     
- Complexity     8193     8213      +20     
============================================
  Files           632      632              
  Lines         46331    46739     +408     
  Branches       8246     8363     +117     
============================================
+ Hits          26151    26425     +274     
- Misses        16465    16601     +136     
+ Partials       3715     3713       -2     
Flag Coverage Δ
unit 38.84% <50.00%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant