-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add service layer support to manage the user defined local authenticators #6071
Add service layer support to manage the user defined local authenticators #6071
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 7 changed files in this pull request and generated no suggestions.
Files not reviewed (2)
- components/application-mgt/org.wso2.carbon.identity.application.common/src/main/java/org/wso2/carbon/identity/application/common/ApplicationAuthenticatorService.java: Evaluated as low risk
- components/application-mgt/org.wso2.carbon.identity.application.common/src/main/java/org/wso2/carbon/identity/application/common/model/VerificationAuthenticatorConfig.java: Evaluated as low risk
Comments skipped due to low confidence (2)
components/application-mgt/org.wso2.carbon.identity.application.common/src/main/java/org/wso2/carbon/identity/application/common/constant/AuthenticatorMgtErrorConstants.java:40
- The error code '60004' is duplicated. It should be unique.
ERROR_BLANK_FIELD_VALUE("60004", "Invalid empty or blank value.",
components/application-mgt/org.wso2.carbon.identity.application.common/src/main/java/org/wso2/carbon/identity/application/common/util/UserDefinedLocalAuthenticatorValidator.java:84
- The method validateDefinedByType references authenticatorConfig.getName(), but authenticatorConfig is not defined in the method scope. This will cause a compilation error.
String.format(error.getDescription(), authenticatorConfig.getName()));
5a98250
to
5bedc63
Compare
2542f32
to
c096f8d
Compare
c096f8d
to
92e8e68
Compare
92e8e68
to
baefb68
Compare
...c/main/java/org/wso2/carbon/identity/application/common/ApplicationAuthenticatorService.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/wso2/carbon/identity/application/common/ApplicationAuthenticatorService.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/wso2/carbon/identity/application/common/ApplicationAuthenticatorService.java
Show resolved
Hide resolved
...ava/org/wso2/carbon/identity/application/common/constant/AuthenticatorMgtErrorConstants.java
Outdated
Show resolved
Hide resolved
Given this introduces a new API resource and scopes it should also be included in "system-api-resource.xml". So that it can be subscribed and accessed from an oauth app via console, or the respective permission to be incorporated to a user role |
61e5978
to
7cbfc23
Compare
4c3d143
to
69baa2f
Compare
.../java/org/wso2/carbon/identity/application/common/util/AuthenticatorMgtExceptionBuilder.java
Outdated
Show resolved
Hide resolved
69baa2f
to
676e93f
Compare
Quality Gate passedIssues Measures |
Reopen with #6172 |
Task issue:
With this PR following changes may introduced.
authenticationType
for UserDefinedLocalAuthenticatorConfig model./authenticators/custom/
Related PRs:
Add DAO layer support to manage the user defined local authenticators #6144
Add unit tests for supporting manage the user defined local authenticators #6072
New API /authenticators/custom to manage user defined local authenticators identity-api-server#736