Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service layer support to manage the user defined local authenticators #6071

Conversation

Thisara-Welmilla
Copy link
Contributor

@Thisara-Welmilla Thisara-Welmilla commented Oct 28, 2024

Task issue:

With this PR following changes may introduced.

  1. Add new property authenticationType for UserDefinedLocalAuthenticatorConfig model.
  2. Improve application authentication service to support managing new local custom authenticators (Local user account identification and 2FA authentication types)
  3. Add permissions and scopes related new API /authenticators/custom/

Related PRs:

@Thisara-Welmilla Thisara-Welmilla changed the title Add new VerificationAuthenticatorConfig for verification authenticators Add service layer support to manage the user defined local authenticators Oct 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 7 changed files in this pull request and generated no suggestions.

Files not reviewed (2)
  • components/application-mgt/org.wso2.carbon.identity.application.common/src/main/java/org/wso2/carbon/identity/application/common/ApplicationAuthenticatorService.java: Evaluated as low risk
  • components/application-mgt/org.wso2.carbon.identity.application.common/src/main/java/org/wso2/carbon/identity/application/common/model/VerificationAuthenticatorConfig.java: Evaluated as low risk
Comments skipped due to low confidence (2)

components/application-mgt/org.wso2.carbon.identity.application.common/src/main/java/org/wso2/carbon/identity/application/common/constant/AuthenticatorMgtErrorConstants.java:40

  • The error code '60004' is duplicated. It should be unique.
ERROR_BLANK_FIELD_VALUE("60004", "Invalid empty or blank value.",

components/application-mgt/org.wso2.carbon.identity.application.common/src/main/java/org/wso2/carbon/identity/application/common/util/UserDefinedLocalAuthenticatorValidator.java:84

  • The method validateDefinedByType references authenticatorConfig.getName(), but authenticatorConfig is not defined in the method scope. This will cause a compilation error.
String.format(error.getDescription(), authenticatorConfig.getName()));
@Thisara-Welmilla Thisara-Welmilla marked this pull request as draft November 6, 2024 03:38
@Thisara-Welmilla Thisara-Welmilla marked this pull request as ready for review November 11, 2024 03:26
@Thisara-Welmilla Thisara-Welmilla changed the base branch from add-user-defined_authenticator_support to custom-local-auth-extensions November 11, 2024 03:28
@Thisara-Welmilla Thisara-Welmilla force-pushed the add-cutsom-auth-configs-service-support branch 2 times, most recently from 5a98250 to 5bedc63 Compare November 19, 2024 04:08
@Thisara-Welmilla Thisara-Welmilla force-pushed the add-cutsom-auth-configs-service-support branch 3 times, most recently from 2542f32 to c096f8d Compare November 22, 2024 03:31
@Thisara-Welmilla Thisara-Welmilla force-pushed the add-cutsom-auth-configs-service-support branch from c096f8d to 92e8e68 Compare November 29, 2024 05:18
@Thisara-Welmilla Thisara-Welmilla force-pushed the add-cutsom-auth-configs-service-support branch from 92e8e68 to baefb68 Compare November 29, 2024 06:17
@Thisara-Welmilla Thisara-Welmilla changed the base branch from custom-local-auth-extensions to master November 29, 2024 07:26
@malithie
Copy link
Member

Given this introduces a new API resource and scopes it should also be included in "system-api-resource.xml". So that it can be subscribed and accessed from an oauth app via console, or the respective permission to be incorporated to a user role

@Thisara-Welmilla Thisara-Welmilla force-pushed the add-cutsom-auth-configs-service-support branch from 61e5978 to 7cbfc23 Compare December 1, 2024 03:46
@Thisara-Welmilla Thisara-Welmilla force-pushed the add-cutsom-auth-configs-service-support branch 7 times, most recently from 4c3d143 to 69baa2f Compare December 2, 2024 06:09
@Thisara-Welmilla Thisara-Welmilla force-pushed the add-cutsom-auth-configs-service-support branch from 69baa2f to 676e93f Compare December 2, 2024 06:47
Copy link

sonarcloud bot commented Dec 2, 2024

@Thisara-Welmilla
Copy link
Contributor Author

Reopen with #6172

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants