Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce maxPasswordAllowedLength config. #6182

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

Malith-19
Copy link
Contributor

Purpose

$subject

Proposed changes in this pull request

With this we are introducing a new config to handle the maximum length allowed for the password. Now the max length validation will be enforced in backend and same config value will be validated from the FE.

The default value will be 64 and if a user wants to increase it they can modify the config in deployment.toml file.

Related issues

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 44.95%. Comparing base (37745ca) to head (ca25392).
Report is 66 commits behind head on master.

Files with missing lines Patch % Lines
...ndlers/PasswordValidationConfigurationHandler.java 0.00% 2 Missing ⚠️
...n/mgt/model/validators/AbstractRulesValidator.java 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6182      +/-   ##
============================================
- Coverage     45.33%   44.95%   -0.39%     
- Complexity    13832    14128     +296     
============================================
  Files          1614     1615       +1     
  Lines         99700   103545    +3845     
  Branches      16833    17888    +1055     
============================================
+ Hits          45196    46544    +1348     
- Misses        47860    50164    +2304     
- Partials       6644     6837     +193     
Flag Coverage Δ
unit 27.86% <75.00%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12195501225

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12195501225
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12195501225

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12251156769

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12251156769
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12251156769

lashinijay
lashinijay previously approved these changes Dec 11, 2024
Copy link

sonarcloud bot commented Dec 13, 2024

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12312642570

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12312642570
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12312642570

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants