-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce maxPasswordAllowedLength config. #6182
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6182 +/- ##
============================================
- Coverage 45.33% 44.95% -0.39%
- Complexity 13832 14128 +296
============================================
Files 1614 1615 +1
Lines 99700 103545 +3845
Branches 16833 17888 +1055
============================================
+ Hits 45196 46544 +1348
- Misses 47860 50164 +2304
- Partials 6644 6837 +193
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
PR builder started |
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12195501225
features/identity-core/org.wso2.carbon.identity.core.server.feature/resources/identity.xml
Show resolved
Hide resolved
...a/org/wso2/carbon/identity/input/validation/mgt/model/validators/AbstractRulesValidator.java
Outdated
Show resolved
Hide resolved
...a/org/wso2/carbon/identity/input/validation/mgt/model/validators/AbstractRulesValidator.java
Outdated
Show resolved
Hide resolved
...2/carbon/identity/input/validation/mgt/test/model/validators/AbstractRulesValidatorTest.java
Show resolved
Hide resolved
...2/carbon/identity/input/validation/mgt/test/model/validators/AbstractRulesValidatorTest.java
Show resolved
Hide resolved
...a/org/wso2/carbon/identity/input/validation/mgt/model/validators/AbstractRulesValidator.java
Outdated
Show resolved
Hide resolved
PR builder started |
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12251156769
…password-max-value-config
Quality Gate passedIssues Measures |
PR builder started |
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12312642570
Purpose
$subject
Proposed changes in this pull request
With this we are introducing a new config to handle the maximum length allowed for the password. Now the max length validation will be enforced in backend and same config value will be validated from the FE.
The default value will be 64 and if a user wants to increase it they can modify the config in deployment.toml file.
Related issues