added data source support #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| List<ApmType> paramNames = parameters.get(1).getList(); | ||
| String[] parts = StringUtils.substringAfter(regex, "/content/").split("/"); | ||
| int paramIndex = 0; | ||
| List<Config> configs = new ArrayList<>(); |
There was a problem hiding this comment.
if you don't know the size of results prefer LinkedList; for constant size lists prefer ArrayList; when you use ArrayList then if you exceed to capacity then the whole items are reallocated in memory which is slow
There was a problem hiding this comment.
the size of it is so small, average 3, that relocation performance is not an issue
# Conflicts: # app/aem/core/src/main/kotlin/com/cognifide/apm/core/grammar/ReferenceFinder.kt # app/aem/core/src/main/kotlin/com/cognifide/apm/core/grammar/argument/ArgumentResolver.kt # app/aem/core/src/main/kotlin/com/cognifide/apm/core/grammar/executioncontext/ExecutionContext.kt
# Conflicts: # app/aem/install/src/main/java/com/cognifide/apm/install/launchers/ApmInstallService.java
# Conflicts: # app/aem/install/src/main/java/com/cognifide/apm/install/launchers/ApmInstallService.java
# Conflicts: # app/aem/core/src/main/kotlin/com/cognifide/apm/core/grammar/ApmType.kt # app/aem/core/src/main/kotlin/com/cognifide/apm/core/grammar/ReferenceFinder.kt # app/aem/core/src/main/kotlin/com/cognifide/apm/core/grammar/ScriptRunner.kt # app/aem/core/src/main/kotlin/com/cognifide/apm/core/grammar/argument/ArgumentResolver.kt # app/aem/core/src/main/kotlin/com/cognifide/apm/core/grammar/executioncontext/ExecutionContext.kt # app/aem/core/src/main/kotlin/com/cognifide/apm/core/grammar/executioncontext/VariableHolder.kt # app/aem/core/src/main/kotlin/com/cognifide/apm/core/grammar/utils/ImportScript.kt # app/aem/core/src/main/kotlin/com/cognifide/apm/core/services/ModifiedScriptFinder.kt # app/aem/core/src/main/kotlin/com/cognifide/apm/core/services/version/VersionServiceImpl.kt # app/aem/core/src/test/groovy/com/cognifide/apm/core/grammar/ScriptRunnerTest.groovy
krystian-panek-vmltech
approved these changes
Oct 25, 2023
# Conflicts: # app/aem/core/src/main/java/com/cognifide/apm/core/grammar/datasource/DataSource.java
# Conflicts: # app/aem/core/src/main/antlr/ApmLang.g4 # app/aem/core/src/test/groovy/com/cognifide/apm/core/grammar/ScriptRunnerTest.groovy # app/aem/core/src/test/resources/define.apm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.