Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid saving user-specific data in instance scripts #816

Open
pun-ky opened this issue Jan 13, 2021 · 4 comments
Open

Avoid saving user-specific data in instance scripts #816

pun-ky opened this issue Jan 13, 2021 · 4 comments

Comments

@pun-ky
Copy link
Contributor

pun-ky commented Jan 13, 2021

Task instanceUp is saving e.g JAVA_EXECUTABLE absolute path in control/\*.\[bat|sh] scripts and  it makes instances not usable directly when extracted externally (outside of GAP usage). 

Consider passing user-specific data to instance scripts using arguments or env vars instead of writing them down to files that could be later a part of instance backups.

Thx @szymon-owczarzak for reporting it!

@szymon-owczarzak
Copy link
Contributor

Or a system variable for the username could be used in JAVA_EXECUTABLE:
C:\Users\%Username%\.gradle\jdks\jdk8u275-b01\bin\java.exe

@pun-ky
Copy link
Contributor Author

pun-ky commented Jan 14, 2021

How about backup made on Unix but reused on windows? 😁 Nope

@szymon-owczarzak
Copy link
Contributor

szymon-owczarzak commented Jan 14, 2021

for *.sh we could use $HOME/.gradle/jdks... and for *.bat %userprofile%/.gradle/jdks..

@pun-ky
Copy link
Contributor Author

pun-ky commented Feb 26, 2021

Distro of Java determined by Gradle could be different for each OS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants