diff --git a/examples/ssh/aem.yml b/examples/ssh/aem.yml index 5f7d0f1..e397306 100644 --- a/examples/ssh/aem.yml +++ b/examples/ssh/aem.yml @@ -28,7 +28,7 @@ instance: http_url: http://127.0.0.1:4503 user: admin password: admin - run_modes: [local, duperp] + run_modes: [local] jvm_opts: - -server - -Djava.awt.headless=true diff --git a/internal/client/client.go b/internal/client/client.go index f88d6ee..6e3dc58 100644 --- a/internal/client/client.go +++ b/internal/client/client.go @@ -116,7 +116,7 @@ func (c Client) RunShellPurely(cmd string) ([]byte, error) { } out, err := cmdObj.CombinedOutput() if err != nil { - if len(out) > 0 { // TODO rethink error handling + if len(out) > 0 { return nil, fmt.Errorf("cannot run command '%s': %w\n\n%s", cmdObj, err, string(out)) } return nil, err diff --git a/internal/provider/instance_model.go b/internal/provider/instance_model.go index 88f87d2..7956ec4 100644 --- a/internal/provider/instance_model.go +++ b/internal/provider/instance_model.go @@ -260,7 +260,7 @@ func (r *InstanceResource) Schema(ctx context.Context, req resource.SchemaReques }, Attributes: map[string]schema.Attribute{ - "files": schema.MapAttribute{ // TODO handle it, instead of copying lib dir + "files": schema.MapAttribute{ MarkdownDescription: "Files or directories to be copied into the machine", ElementType: types.StringType, Computed: true, @@ -293,13 +293,6 @@ func (r *InstanceResource) Schema(ctx context.Context, req resource.SchemaReques }, }, }, - PlanModifiers: []planmodifier.List{ - listplanmodifier.UseStateForUnknown(), - listplanmodifier.RequiresReplaceIf(func(ctx context.Context, request planmodifier.ListRequest, response *listplanmodifier.RequiresReplaceIfFuncResponse) { - // TODO check if: [1] list is not empty; [2] the same instances are still created; [3] dirs have not changed - // response.RequiresReplace = true - }, "If the value of this attribute changes, Terraform will destroy and recreate the resource.", "If the value of this attribute changes, Terraform will destroy and recreate the resource."), - }, }, }, }