-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xtag.queryChildren #166
Comments
the queryChildren method was specifically for querying for selector matches among the immediate children of an element. |
@csuwildcat I get that, after typing it out. What do you think about simplifying the API, though? I'm proposing we use |
OK, here's how we could do this:
Thoughts? |
I like that approach. DEEP=true is the same as SHALLOW=false :) I think SHALLOW=false is more explicit. Makes more sense to enable the shallow functionality, rather than disable the default. |
What does
xtag.queryChildren
do?If I did
xtag.queryChildren(daveElement, '.a')
, would it only select<div class="a">
and not<div class="a sub">
?I think the method name could be something like
xtag.queryShallow()
OR...
It could be an internal method that is used by
xtag.query(ELEMENT, SELECTOR, DEEP=true)
when a boolean is passed. e.g.xtag.query(daveElement, '.a', false)
. This would simplify the API a bit.The text was updated successfully, but these errors were encountered: