Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphical problems rendering big groups of cauldrons #528

Open
BlueGradientHorizon opened this issue Oct 17, 2024 · 7 comments
Open

Graphical problems rendering big groups of cauldrons #528

BlueGradientHorizon opened this issue Oct 17, 2024 · 7 comments

Comments

@BlueGradientHorizon
Copy link

BlueGradientHorizon commented Oct 17, 2024

Describe the bug

As stated in the title. Graphical corruptions are seen when rendering big groups of cauldrons. Mostly as it seems to me it is happening on chunk borders.

VM behaviour (latest dev branch, action artifact):

2024-10-17_16 51 38
2024-10-17_16 52 11

Vanilla 1.21.1 behaviour:

2024-10-31_10 54 34
2024-10-31_10 55 03

Test map used: test_map.zip

Steps to reproduce

  1. Create superflat world.
  2. Use /fill command to create groups of cauldrons.
  3. Do it several times if needed, make sure group of cauldrons is partially located in 2-5 different chunks.

Log files

latest.log, but I don't think it will be helpful in any way

@NXTler
Copy link
Contributor

NXTler commented Oct 27, 2024

This is not really a VulkanMod bug. You are running into the vertex limit of u32, which is the same as Vanilla. Sodium only uses u16, but gets away with it in most cases due to having greedy meshing.

@NXTler
Copy link
Contributor

NXTler commented Oct 27, 2024

This can be closed.

@BlueGradientHorizon
Copy link
Author

Ok, I understand, but will some sort of workaround be implemented in VM? I mean, is it planned in the future? And, is where an already opened issue regarding this problem? If not, are you sure that this one should be closed?

@NXTler
Copy link
Contributor

NXTler commented Oct 28, 2024

The only way to improve is by either increasing the vertix limit, which is extremely resource intensive, or by implementing other optimizations such as greedy meshing.
I'm not sure if there are any plans to improve this behavior in the future.

@NXTler
Copy link
Contributor

NXTler commented Oct 28, 2024

Besides this issue doesn't have the highest priority, as we are still vanilla compliant.

@Felix14-v2
Copy link

Felix14-v2 commented Oct 30, 2024

but gets away with it in most cases due to having greedy meshing

Wait, does Sodium has greedy meshing?

Mostly as it seems to me it is happening on chunk borders.

Does this happen in vanilla too? If not, then this is a regression and a valid issue that shouldn't be closed.

@BlueGradientHorizon
Copy link
Author

BlueGradientHorizon commented Oct 31, 2024

Does this happen in vanilla too?

I've just tested the same map in vanilla mc 1.21.1 and the whole group of cauldrons is rendered absolutely fine, so it is indeed not a vanilla compliant behaviour, but a rendering issue.

Issue edited, screenshots with vanilla mc behaviour were added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants