Spirit fall-damage passive is disabled when a player is also an Earthbender.

[Tredecate]

In the Spirit passive event listener, the fourth condition of the if-statement on the referenced line causes the passive to be ignored if the player is also an Earthbender. While this check makes sense for Air, it causes some issues with Earth.

Spirits with Earth as a secondary element take fall damage on non-earthbendable blocks, despite the fact that being a Spirit should prevent all fall damage.

Suggested fix: Remove the fourth condition in the referenced line.

Spirits/src/main/java/me/numin/spirits/listeners/Passives.java

Line 22 in 4b41026

if (event.isCancelled() || bPlayer == null || bPlayer.hasElement(Element.AIR) || bPlayer.hasElement(Element.EARTH)) {

[xNuminousx]

I could replace it with a bound ability check but the purpose for that additional check is because this passive affects abilities that require falling. For example, Shockwave has a fall feature where if you fall from a height then Shockwave automatically activates and sends out a wave. That 4th check you're referring to was added as a way to prevent this passive from interrupting moves like Shockwave.

I could add a check that checks for bound ability (like if you are on the Shockwave slot) instead of element but this could cause some problems when dealing with addons and such.

Thank you for submitting an issue.

[Tredecate]

Oh, interesting. I see the issue.

Would this perhaps best involve a tweak on the PK side of things first, and then over here? Or could there be some roundabout way to still trip Shockwave and supporting moves all from Spirits?

I'm still fairly new to some of this stuff 😅

[Tredecate]

Interestingly enough, PhanaticD just employed the fix I outlined and I tested it on his server. Shockwave seems to work fine.

[xNuminousx]

Interestingly enough, PhanaticD just employed the fix I outlined and I tested it on his server. Shockwave seems to work fine.

This issue was reported to me a long time ago and I added it as a fix. If it’s no longer an issue, i’ll do some testing and see what I can do.