Use of RCS for node.ks leads to inaccurate burns

[hany]

Hi there,

It seems as though this code block:

kos-ramp/ramp/node.ks

Lines 59 to 67 in b25f112

	until utilIsShipFacing(steerDir, node_bestFacing, 0.5) or
	nn:eta <= dt and utilIsShipFacing(steerDir, node_okFacing, 5) or
	ship:angularvel:mag < 0.0001 and rcs = true
	{
	if ship:angularvel:mag < 0.01 rcs on.
	stagingCheck().
	if not warped { set warped to true. physWarp(1). }
	wait 0.
	}

Is leading to some inaccurate burns. For example, when running transfer.ks to go from Kerbin to Minmus, during the execution of node_hoh.ks and node.ks, while the ship is being rotated and RCS is being used, the current orbit’s eccentricity (along with current Ap and Pe) is shifted (slightly). This results in the transfer missing the encounter as the Hohmann transfer was calculated with the previous orbit. Without RCS, the current orbit remains undisturbed and accurate burns are achieved.

Some thoughts on this:

1. Remove the use of RCS to rotating/alignment (or make it optional?).
2. Recalculate node once adjustment is made.

[astappiev]

Try now, if a ship can rotate without RCS, they will not be enabled anymore.