Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] CLI improvement #17

Open
kolyshkin opened this issue Oct 23, 2015 · 3 comments
Open

[RFC] CLI improvement #17

kolyshkin opened this issue Oct 23, 2015 · 3 comments

Comments

@kolyshkin
Copy link
Contributor

moctl tool with two main types of entities:
1 a mosaic (as a whole);
2 an (individual) volume.

These two types are very different in nature, but the moctl actions we use on them are sometimes intersect. In particular, moctl mount and moctl umount can refer to the mosaic or a volume, so we have to introduce a special volume name, -, meaning "the mosaic itself".

Currently, we have almost 10 volume-related commands, and only 3 mosaic commands (mount, umount and info). To avoid confusion, I propose to prepend the literal word mosaic for mosaic-related commands, leaving volume-related ones as is.

Example:
moctl NAME mount - MOUNTPOINT --> moctl NAME mosaic mount MOUNTPOINT

The alternative I considered (and refused) is to use volume for where the volume name is, such as: moctl NAME mount volume VOLNAME MOUNTPOINT for volume, and moctl NAME mount MOUNTPOINT for the mosaic itself.

What do you think?

@xemul
Copy link
Owner

xemul commented Oct 23, 2015

Too many keystrokes :(

@kolyshkin
Copy link
Contributor Author

Same as with short vs long options, it's either clarity or brevity. I prefer clarity over brevity.

Alternatively, we can have two commands, one for volumes, one for mosaic.

@xemul
Copy link
Owner

xemul commented Oct 26, 2015

Frankly, I see no problems with "moctl " semantics. Really. Yes, for some actions target can be only one of mosaic/volume, for some (mount and umount currently) they intersect, but reserving '-' as a volume name that means 'mosaic' in intersecting cases is OK. From my perspective.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants