Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment progress in xOpera CLI #191

Open
mihaTrajbaric opened this issue Mar 24, 2021 · 3 comments
Open

Deployment progress in xOpera CLI #191

mihaTrajbaric opened this issue Mar 24, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@mihaTrajbaric
Copy link
Contributor

mihaTrajbaric commented Mar 24, 2021

During deploying, xOpera's stack trace looks like this:

[Worker_0]   Deploying snow-security-rules_0
[Worker_0]     Executing create on snow-security-rules_0
[Worker_0]   Deployment of snow-security-rules_0 complete
[Worker_0]   Deploying snow-vm_0
[Worker_0]     Executing create on snow-vm_0
[Worker_0]   Deployment of snow-vm_0 complete
[Worker_0]   Deploying snow-docker-host_0
[Worker_0]     Executing create on snow-docker-host_0
[Worker_0]   Deployment of snow-docker-host_0 complete
[Worker_0]   Deploying snow-api_0
[Worker_0]     Executing create on snow-api_0
[Worker_0]   Deployment of snow-api_0 complete

It would be a useful feature to display deployment progress (which node of how many xOpera is processing at the moment), possibly like this:

[Worker_0]  [Node 1/4]  Deploying snow-security-rules_0
[Worker_0]  [Node 1/4]     Executing create on snow-security-rules_0
[Worker_0]  [Node 1/4]   Deployment of snow-security-rules_0 complete
[Worker_0]  [Node 2/4]   Deploying snow-vm_0
[Worker_0]  [Node 2/4]     Executing create on snow-vm_0
[Worker_0]  [Node 2/4]   Deployment of snow-vm_0 complete
[Worker_0]  [Node 3/4]   Deploying snow-docker-host_0
[Worker_0]  [Node 3/4]     Executing create on snow-docker-host_0
[Worker_0]  [Node 3/4]   Deployment of snow-docker-host_0 complete
[Worker_0]  [Node 4/4]   Deploying snow-api_0
[Worker_0]  [Node 4/4]     Executing create on snow-api_0
[Worker_0]  [Node 4/4]   Deployment of snow-api_0 complete
@anzoman
Copy link
Contributor

anzoman commented Mar 24, 2021

@mihaTrajbaric thanks, this would be a useful feature for the user to see how far the deployment goes.

@anzoman anzoman added the enhancement New feature or request label Mar 24, 2021
@anzoman
Copy link
Contributor

anzoman commented May 17, 2021

After some time, although it looks good at first, I think that this feature is not needed and could be just another distraction when running opera deploy.

If we really need to show the deployment progress, I would recommend that we put it to the json/yaml output that is returned by our opera info command (we can add a new progress key that would show the percentage).

@cankarm, @dradX, @sstanovnik what do you think?

@sstanovnik
Copy link
Member

I'd still keep this in a wishlist. In its current state, we don't have enough information to make good design decisions about how to implement progress. Some things we'd need to consider:

  • progress of what out of what
  • will the progress work with more than one worker
  • will we have progress reports from executors
  • if so, will we have a high-pass filter for long-running tasks so we don't pollute the outputs
  • is this even technically possible (I assume it is, but you never know)
  • would we introduce a huge maintenance overhead because I don't think anything was designed to keep track of progress, and this is Python after all
  • do we engage in ETC approximation

And lastly, like you suggested, we'd need to decide if and how to display progress via info for concurrent command execution (with e.g. xopera-api). Would we have a simple (quite useless) percentage or a more verbose data structure reporting stages.

In summary, I vote keep as wishlist. Not enough bang for our limited buck.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants