Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get all errors with opera validate command #192

Open
mihaTrajbaric opened this issue Mar 24, 2021 · 5 comments
Open

Get all errors with opera validate command #192

mihaTrajbaric opened this issue Mar 24, 2021 · 5 comments
Labels
duplicate This already exists somewhere enhancement New feature or request

Comments

@mihaTrajbaric
Copy link
Contributor

In the case of error(s) in TOSCA, opera validate command returns the first one. It would be a useful feature if it could return all of them.

@anzoman
Copy link
Contributor

anzoman commented Mar 24, 2021

Hi @mihaTrajbaric thanks for opening this. I have searched though history and have found a similar issue #50. I agree, it would be really helpful to see more than one error.

@anzoman anzoman added enhancement New feature or request duplicate This already exists somewhere labels Mar 24, 2021
@cankarm
Copy link
Contributor

cankarm commented Mar 25, 2021

Collecting all errors is practically impossible, due to the potential implication of the first error on the understanding of the following code. It would be good to limit on simple subsets of errors that we can cover.

@dradX
Copy link

dradX commented Mar 25, 2021

@cankarm The issue here is to simply show any possible parsing error during the generation of the template tree - not going much into implementation checks.

@cankarm
Copy link
Contributor

cankarm commented Mar 25, 2021

Sure @dradX, I assumed that, but it would be better if the issue would be more to the point with an example if possible. Anyway, I still think that this could be a very hard task to implement if we don't limit it to e.g. next few parsing errors. Or maybe just try also some other static analysis to achieve that.

@anzoman
Copy link
Contributor

anzoman commented Mar 26, 2021

As @cankarm said, this feature seems easy to implement at first, but we might find some difficulties when trying to do so. Validation process includes some stages when going through the TOSCA service template and by catching all the TOSCA inconsistencies it would mean that we could ignore some fatal errors and continue with validation, which may result in some variables being undefined for the next step of validation. This is just an example of what might happen, but there is also a possibility that the potential implementation would go smooth and without any problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This already exists somewhere enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants