Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post Argus Webhook fields in question... #15

Open
joe94 opened this issue Oct 7, 2020 · 1 comment
Open

Post Argus Webhook fields in question... #15

joe94 opened this issue Oct 7, 2020 · 1 comment

Comments

@joe94
Copy link
Member

joe94 commented Oct 7, 2020

Once we switch to Argus, webhook expirations will be driven by Argus' TTL of the entries in its database.

This is making me question the precise role of fields such as Until and especially Duration
Source: https://github.com/xmidt-org/webpa-common/blob/main/webhook/webhook.go#L55

For Duration: we're always setting this value to 5 mins and I don't really see it being used except for times when Until is not defined.

For Until: I can see this field being a more immediate way for caduceus to know whether to keep sending events or not to a subscriber. However, the list of subscribers will be eventually refreshed through Argus anyways.

@kristinapathak
Copy link
Contributor

I remember discussing the Argus TTL when planning Mimisbrunnr, and there was a real reason that we kept ExpiresAt in the object stored with Argus...
https://github.com/xmidt-org/mimisbrunnr/blob/main/model/model.go#L29

I don't remember the specifics, so I can look into it more and see if I can remember/find those details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants