Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Matcher field from webhook struct #17

Open
kristinapathak opened this issue Aug 7, 2020 · 0 comments
Open

Remove Matcher field from webhook struct #17

kristinapathak opened this issue Aug 7, 2020 · 0 comments
Labels
api-breaking-change Changes that will require a major version bump

Comments

@kristinapathak
Copy link
Contributor

https://github.com/xmidt-org/webpa-common/blob/179b0f36052587995ad5927313fbec7b6e14be9c/webhook/webhook.go#L50

Moving forward, we only want to filter events based on the destination. Once this change is imported into scytale, tr1d1um, and caduceus, I believe we will need to increase their api version.
@joe94 joe94 transferred this issue from xmidt-org/webpa-common Feb 18, 2021
@joe94 joe94 added the api-breaking-change Changes that will require a major version bump label Feb 22, 2021
@schmidtw schmidtw mentioned this issue Aug 31, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api-breaking-change Changes that will require a major version bump
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joe94 @kristinapathak