You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently the ContentType in the webhook registration is used to determine whether to send the full WRP or just the Payload. We are proposing changing the functionality of the ContentType to instead be used for content negotiation between Caduceus and its webhooks.
If the ContentType specified in the WRP doesn't match what the webhook wants, Caduceus will drop the event instead of sending it.
Ideally, we want to add a field to the webhook struct called Accept or AcceptHeader that specifies a semi-colon deliminated list of MIME ContentTypes that the webhook will accept. Then the ContentType field can be treated as a list of one when no values are given in the Accept field (in order to support backwards compatibility) or deprecated.
The text was updated successfully, but these errors were encountered:
https://github.com/xmidt-org/webpa-common/blob/7592f89376a7f05449299ec1391ef8456a87b3fe/webhook/webhook.go#L32
Currently the ContentType in the webhook registration is used to determine whether to send the full WRP or just the Payload. We are proposing changing the functionality of the ContentType to instead be used for content negotiation between Caduceus and its webhooks.
If the ContentType specified in the WRP doesn't match what the webhook wants, Caduceus will drop the event instead of sending it.
Ideally, we want to add a field to the webhook struct called
Accept
orAcceptHeader
that specifies a semi-colon deliminated list of MIME ContentTypes that the webhook will accept. Then theContentType
field can be treated as a list of one when no values are given in theAccept
field (in order to support backwards compatibility) or deprecated.The text was updated successfully, but these errors were encountered: