You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After @kristinapathak pointed out that the docs explicitly say that logging should be done in the ServerErrorEncoder even when the ServerErrorLogger got deprecated for the ServerErrorHandler, I think (if we're interested in logging errors such as "ItemNotFound"), we could log them at the debug level in the ServerErrorEncoder
Source: https://pkg.go.dev/github.com/go-kit/kit/transport/http#ServerErrorHandler
ServerErrorHandler is used to handle non-terminal errors.
By default, non-terminal errors are ignored. This is intended as a diagnostic measure.
Finer-grained control of error handling, including logging in more detail, should be performed
in a custom ServerErrorEncoder or ServerFinalizer, both of which have access to the context.
The handlers in this file https://github.com/xmidt-org/argus/blob/main/store/handler.go#L40 could be configured with gokit's
ServerErrorHandler
option to at least log all the errors.The text was updated successfully, but these errors were encountered: