Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration to allow for aarch64 hosts in Dockerfile #265

Open
Zacharias opened this issue May 1, 2023 · 1 comment · Fixed by #270
Open

Add configuration to allow for aarch64 hosts in Dockerfile #265

Zacharias opened this issue May 1, 2023 · 1 comment · Fixed by #270
Assignees

Comments

@Zacharias
Copy link
Contributor

Spruce is pulled in to the Dockerfile as a binary dependency. It is used in entrypoint.sh to merge configuration files to control the behavior of scytale.

It's sourcing can be seen here:

# https://github.com/xmidt-org/scytale/blob/main/Dockerfile#L21
# Download spruce here to eliminate the need for curl in the final image
RUN mkdir -p /go/bin && \
    curl -L -o /go/bin/spruce https://github.com/geofffranks/spruce/releases/download/v1.29.0/spruce-linux-amd64 && \
    chmod +x /go/bin/spruce

Since we want the ability to build and run scrytale on a variety of processor architectures, we need to find a way to get a processor-architecture-specific copy of spruce installed. This could added by adding configuration around processor architectures, or alternatively building spruce from source and including it in the dockerfile.

@Zacharias
Copy link
Contributor Author

Zacharias commented May 3, 2023

Did some looking into https://github.com/geofffranks/spruce/releases/ and I do see a arm64 download listed, which is a now-deprecated nomenclature for the aarch64 ISA. The docker image for golang shows the following when ran:

% docker run -it golang:1.19-alpine /bin/sh
/go # uname -a
Linux ff721415d026 6.2.13-300.fc38.aarch64 #1 SMP PREEMPT_DYNAMIC Thu Apr 27 01:54:55 UTC 2023 aarch64 Linux
/go # uname -m
aarch64
/go # exit

@Zacharias Zacharias self-assigned this May 3, 2023
@Zacharias Zacharias linked a pull request May 4, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant