Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More configurable options for parsing device ID from event #130

Closed
wants to merge 4 commits into from
Closed

More configurable options for parsing device ID from event #130

wants to merge 4 commits into from

Conversation

kristinapathak
Copy link
Contributor

fixes #100

@kristinapathak kristinapathak added the enhancement New feature or request label Jul 27, 2020
@kristinapathak kristinapathak added this to the Unreleased milestone Jul 27, 2020
@kristinapathak kristinapathak requested a review from kcajmagic July 27, 2020 23:23
@kristinapathak kristinapathak self-assigned this Jul 27, 2020
kcajmagic
kcajmagic reviewed Jul 28, 2020
View reviewed changes
Copy link
Member

@kcajmagic kcajmagic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

eventParser/eventParser.go Outdated Show resolved Hide resolved
@kristinapathak
Copy link
Contributor Author

Closing this because different changes need to be made.

@kristinapathak kristinapathak deleted the wrp-parsing branch July 6, 2021 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcajmagic kcajmagic kcajmagic left review comments

Assignees

@kristinapathak kristinapathak

Labels
enhancement New feature or request
Projects
None yet
Milestone
Unreleased
Development

Successfully merging this pull request may close these issues.

Make rules more generic
2 participants
@kristinapathak @kcajmagic