Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standardize metrics naming #541

Open
ilawjr opened this issue Jul 12, 2024 · 0 comments
Open

standardize metrics naming #541

ilawjr opened this issue Jul 12, 2024 · 0 comments

Comments

@ilawjr
Copy link

ilawjr commented Jul 12, 2024

Right now our metrics are a hodge-podge of names. For example, here are the names for api requests on our different services:

xmidt_caduceus_api_requests_total
xmidt_petasos_api_requests_total
xmidt_scytale_api_requests_total
xmidt_talaria_api_requests_total

xmidt_argus_server_request_count
xmidt_themis_server_request_count
webpa_tr1d1um_server_request_count

this metric in particular has the job and role labels, so having the server name in the metric itself is redundant. Following a standard naming convention like node_exporter does would make creation and re-use of charts (e.g. grafana) much easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant