Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to Create a New Tag for webpa-common and update Talaria with the latest webpa-common tag #1078

Closed
chaitanyasingla-dt opened this issue Nov 22, 2024 · 6 comments
Assignees

Comments

@chaitanyasingla-dt
Copy link
Contributor

The changes introduced in Pull Request #439 were successfully merged into the master branch. However, these changes are not present in the latest tag for the webpa-common repository.

Request:
Please create a new tag for the webpa-common repository that includes the changes from Pull Request #439.
Ensure that the latest changes from webpa-common, including Pull Request #439, are integrated into Talaria.
Create a new tag for Talaria with the updated dependency on the latest webpa-common version.

@denopink
Copy link
Contributor

denopink commented Dec 3, 2024

Working on it 👍

@denopink
Copy link
Contributor

denopink commented Dec 4, 2024

@denopink denopink closed this as completed Dec 4, 2024
@chaitanyasingla-dt
Copy link
Contributor Author

Hi @denopink
The changes are still not present in the latest webpa-common tag you created.
Can you please check?

@denopink
Copy link
Contributor

denopink commented Dec 5, 2024

@diogoViana95 @chaitanyasingla-dt looks like #439 was merged into the wrong branch.

Please use main as the base and not master, master is no longer used in many (if not all) of repos 🙂

@denopink denopink reopened this Dec 5, 2024
@denopink
Copy link
Contributor

denopink commented Dec 5, 2024

Create a new pr with main as the base and I'll review it as soon as I can and I'll re-release.

Closing this issue.

@denopink denopink closed this as completed Dec 5, 2024
@denopink
Copy link
Contributor

denopink commented Dec 5, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants