Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xo config overrides in package.json are ignored #9

Open
squarefeet opened this issue Apr 12, 2017 · 1 comment
Open

xo config overrides in package.json are ignored #9

squarefeet opened this issue Apr 12, 2017 · 1 comment

Comments

@squarefeet
Copy link

When specifying an overrides section in the xo config in package.json, any file globbing patterns or paths will never match.

When xo runs, it is setting the cwd to be the parent directory of the file being linted, rather than the parent directory of the package.json file that it found the xo config in so when optionsManager.findApplicableOverrides( ... ) is called, it will never return anything.

I did note that one can apparently set the chdir setting in SublimeLinter itself to be the project's root ("chdir": "${project}") however that hasn't made any difference to my problem.

Could it be that the xo linter is ignoring the chdir setting?

@umaar
Copy link

umaar commented Apr 24, 2017

Hey @squarefeet 🙂 I was having a similar issue and came across this! Just a heads up, the optionsManager.findApplicableOverrides you mentioned is part of the xo project here: https://github.com/sindresorhus/xo/blob/5209ec86412cdbbee6a2bcae860faf40fbfb51a9/index.js#L19 - if it's a bug in xo core, it could be suitable over there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants