Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmarks against FSDP2.0 with torch.compile #8

Open
RunFMe opened this issue Jun 25, 2024 · 1 comment
Open

Add benchmarks against FSDP2.0 with torch.compile #8

RunFMe opened this issue Jun 25, 2024 · 1 comment

Comments

@RunFMe
Copy link

RunFMe commented Jun 25, 2024

FSDP2.0 supports tracing with torch.compile, which could potentially change the comparison results against YaFSDP.
Could you add the comparison against FSDP2.0+torch.compile to the list of benchmarks?

@antony-frolov
Copy link
Contributor

FSDP2 is not supported in accelerate as of now and adding the support would require quite a bit of work. As soon as FSDP2 is supported in 🤗 stack we'll be happy to provide a comparison against it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants