Decay OidMap type for connection_info's connection #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To do not confuse user with error on this snippet const auto oid_map = ozo::register_types<>(); ozo::connection_info<decltype(oid_map)> conn_info(...) Here the connection_info uses connection with const od oid map type, that deletes move constructor of the underlying connection_rep type.
elsid
requested changes
Nov 5, 2020
| @@ -30,7 +30,7 @@ class connection_info { | |||
| Statistics statistics; | |||
|
|
|||
| public: | |||
| using connection_type = std::shared_ptr<ozo::connection<OidMap, Statistics>>; //!< Type of connection which is produced by the source. | |||
| using connection_type = std::shared_ptr<ozo::connection<std::decay_t<OidMap>, Statistics>>; //!< Type of connection which is produced by the source. | |||
There was a problem hiding this comment.
Should we check this by tests? Use static_assert or just apply same aproach as in the snippet somewhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To do not confuse the user with error on this snippet
Here the connection_info uses the connection with const od oid map type,
that deletes move constructor of the underlying connection_rep type.