Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide BaseType as string #5

Open
yanickrochon opened this issue Mar 15, 2015 · 0 comments
Open

Provide BaseType as string #5

yanickrochon opened this issue Mar 15, 2015 · 0 comments

Comments

@yanickrochon
Copy link
Owner

Right now, the implementation requires the actual base type prototype. Since errors are cached, it should be possible to pass either the base type as string, or the actual error type itself. If the base type, as string, is not a known error type, an exception should be thrown.

Therefore, instead of

var CustomError = errorFactory('CustomError', ..., errorFactory('BaseType'));

it should be

var CustomError = errorFactory('CustomError', ..., 'BaseType');
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant