Fix shellcheck issues for completion

yankeexe · Jan 23, 2022 · ab52fe6 · ab52fe6
1 parent 088efb0
commit ab52fe6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/completions/_wt_completion b/completions/_wt_completion
@@ -17,7 +17,7 @@ declare -A opts
 setopt shwordsplit
 for item in $list
 do
-    base="$(basename ${item} | xargs)"
+    base="$(basename -- "$item")"
     opts+=(["$base"]="$base")
 done
 unsetopt shwordsplit

diff --git a/completions/wt_completion b/completions/wt_completion
@@ -17,14 +17,15 @@ _wt() {
 
     for item in $list
     do
-        opts+="$(basename "$item") "
+        opts+="$(basename -- "$item") "
     done
 
     # Only show suggestions for the root command (wt)
     # Pass autocompletion suggestion as "words (-W)" to `compgen` separated by space
     if [[ ${cur} == -* || ${COMP_CWORD} -eq 1 ]] ; then
         local cur=${COMP_WORDS[COMP_CWORD]}
-        COMPREPLY=( $(compgen -W "${opts}" -- "$cur") )
+        # shellcheck disable=SC2207
+        COMPREPLY=( $(compgen -W "$opts" -- "$cur") )
     fi
 }