-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid creating a new shell instance when using wt #15
base: master
Are you sure you want to change the base?
Conversation
b1ce5de
to
9c6fef8
Compare
This is to avoid creating a new shell instance when using wt.
9c6fef8
to
0fd098a
Compare
09ae217
to
97f896f
Compare
Also use it inside the generated init functions.
Hello. Doing All of this would only need I'll be working on this today, and comparing it with your work, but I'd like to keep this as simple as possible. I'd like to package this so I'd like the setup needed to be minimal. I'll be incorporating some changes you mage (like #16). |
Well I'll be packaging your fork as simple modifications probably won't do this well enough for publishing. Thanks for your work! |
Awesome stuff! Also, thank you! As you saw, I have developed my fork a bit. Feel free to open a PR there! |
My changes aren't something you'd want in your package. I ripped out the update functionality as The last modification I did, which I may open a PR for, is that the |
I have also packaged it for nix :D (sort of) in my config. It also removes the update functionality with a patch. I think it might be best to not handle updates and have it distributed via a package manager. |
I saw that but IMHO the better to change the If you're interested here's my PR to |
Fair enough, maybe we should change |
This PR creates shell functions that invoke
wt
and cd into the given directory. This partially solves #11.What changed:
wt
and giving it a valid worktree name, itecho
's outchangedir:<path>
.init
sub-command for generating the shell code of the function.I believe some further changes would be nice, but might be outside the scope of this PR:
--
prefix for the sub-commands, to avoid collisions with worktree names.init
operation could also generate the completion scripts to reduce installation complexity. (This could be implemented in this PR)Some notes:
wt
, the whole script could be inside the shell function, thus not needing the ugly echoing.