-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Select zone as scoring object. #1906
Open
jagodek
wants to merge
12
commits into
master
Choose a base branch
from
1891-select-detector-in-sidebar-for-scoring
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grzanka
reviewed
Dec 29, 2024
grzanka
reviewed
Dec 29, 2024
grzanka
reviewed
Dec 29, 2024
grzanka
reviewed
Dec 29, 2024
grzanka
reviewed
Dec 29, 2024
src/ThreeEditor/components/Sidebar/properties/category/QuantityConfiguration.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to improve the scoring functionality in the
ThreeEditor
module, particularly focusing on theScoringOutput
class and related components. The changes introduce new features such as handling different scoring types (detector and zone) and updating the UI components to reflect these changes.Enhancements to Scoring Functionality:
src/ThreeEditor/Simulation/Scoring/ScoringOutput.ts
:zoneUuid
andscoringType
toScoringOutputJSON
and corresponding private fields_zone
and_scoringType
to theScoringOutput
class. [1] [2]zone
,scoringType
, anddetector
.toJSON
andfromJSON
methods to include the new properties. [1] [2]removeAllQuantities
to clear all quantities from the scoring output.src/ThreeEditor/Simulation/Scoring/ScoringManager.ts
:getOutputByQuantityUuid
to retrieve a scoring output by a quantity UUID.UI and Component Updates:
src/ThreeEditor/components/Dialog/ChangeScoringTypeDialog.tsx
:src/ThreeEditor/components/Sidebar/properties/category/OutputConfiguration.tsx
:src/ThreeEditor/components/Sidebar/properties/category/ObjectInfo.tsx
:Additional Changes:
src/ThreeEditor/Simulation/Scoring/ScoringOutputTypes.ts
:src/ThreeEditor/Simulation/Zones/ZoneManager.ts
:getZoneOptionsForScoring
to retrieve zone options formatted for scoring.These changes collectively enhance the flexibility and functionality of the scoring system, allowing for more precise and varied simulation configurations.