Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug?]: Sherlock for Yarn Broken #5709

Closed
1 task
jacoboneill opened this issue Aug 31, 2023 · 1 comment · Fixed by #5788
Closed
1 task

[Bug?]: Sherlock for Yarn Broken #5709

jacoboneill opened this issue Aug 31, 2023 · 1 comment · Fixed by #5788
Labels
bug Something isn't working

Comments

@jacoboneill
Copy link

Self-service

  • I'd be willing to implement a fix

Describe the bug

Made a issue #5708. When opened I got an email saying that sherlock failed.

To reproduce

Make an issue

Environment

N/A

Additional context

Screenshot 2023-08-31 at 20 05 53
@jacoboneill jacoboneill added the bug Something isn't working label Aug 31, 2023
@jakub-g
Copy link

jakub-g commented Oct 13, 2023 •
edited
Loading

Last good exec was Jun 23, 100% failing since

https://github.com/yarnpkg/berry/actions/workflows/sherlock-workflow.yml?query=is%3Asuccess

@clemyan clemyan mentioned this issue Oct 13, 2023
Merged
3 tasks
arcanis added a commit that referenced this issue Oct 18, 2023
@clemyan @arcanis
Fix sherlock workflow again (#5788)
77d7306 
**What's the problem this PR addresses?**
<!-- Describe the rationale of your PR. -->
<!-- Link all issues that it closes. (Closes/Resolves #xxxx.) -->

After upgrading alpine for the sherlock workflow in #5718, the workflow
still fails due to newer versions of alpine no longer having the
`python2` package.

Fixes #5709

**How did you fix it?**
<!-- A detailed description of your implementation. -->

Since we removed the old website in #5742, berry no longer depends on
`sharp` so I just removed all the alpine packages needed to build
`sharp` including `python2`

**Checklist**
<!--- Don't worry if you miss something, chores are automatically
tested. -->
<!--- This checklist exists to help you remember doing the chores when
you submit a PR. -->
<!--- Put an `x` in all the boxes that apply. -->
- [x] I have read the [Contributing
Guide](https://yarnpkg.com/advanced/contributing).

<!-- See
https://yarnpkg.com/advanced/contributing#preparing-your-pr-to-be-released
for more details. -->
<!-- Check with `yarn version check` and fix with `yarn version check
-i` -->
- [x] I have set the packages that need to be released for my changes to
be effective.

<!-- The "Testing chores" workflow validates that your PR follows our
guidelines. -->
<!-- If it doesn't pass, click on it to see details as to what your PR
might be missing. -->
- [x] I will check that all automated PR checks pass before the PR gets
reviewed.

Co-authored-by: Maël Nison <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix sherlock workflow again clemyan/berry
2 participants
@jakub-g @jacoboneill