Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug?]: pnpm is not listed as an option in config for nodeLinker #5847

Closed
1 task
trivikr opened this issue Oct 24, 2023 · 1 comment · Fixed by #5850
Closed
1 task

[Bug?]: pnpm is not listed as an option in config for nodeLinker #5847

trivikr opened this issue Oct 24, 2023 · 1 comment · Fixed by #5850
Labels
bug Something isn't working

Comments

@trivikr
Copy link
Contributor

trivikr commented Oct 24, 2023

Self-service

  • I'd be willing to implement a fix

Describe the bug

The pnpm option is not listed as an option in config for nodeLinker

It is listed in documentation https://yarnpkg.com/configuration/yarnrc#nodeLinker

To reproduce

$ yarn --version
4.0.0

$ yarn config nodeLinker
└─ nodeLinker
   ├─ Description: The linker used for installing Node packages, one of: "pnp", "node-modules"
   ├─ Source: <default>
   └─ Value: 'pnp'

Environment

System:
    OS: macOS 14.0
    CPU: (8) arm64 Apple M1 Pro
  Binaries:
    Node: 18.18.0 - /private/var/folders/42/54jl1_3x4hz06cf7bc_kzd4h0000gn/T/xfs-988ceb7a/node
    Yarn: 4.0.0 - /private/var/folders/42/54jl1_3x4hz06cf7bc_kzd4h0000gn/T/xfs-988ceb7a/yarn
    npm: 9.8.1 - ~/Library/Caches/fnm_multishells/39477_1698170213522/bin/npm

Additional context

No response
@trivikr trivikr added the bug Something isn't working label Oct 24, 2023
This was referenced Oct 24, 2023
Closed
Merged
@arcanis
Copy link
Member

arcanis commented Oct 24, 2023

It's not an enum in the yarnrc.json because, technically, plugins may add different values for this field (and the yarnrc.json is used by some IDE / extensions for actual .yarnrc.yml content validation).

github-merge-queue bot pushed a commit that referenced this issue Oct 24, 2023
@trivikr @merceyz
chore(plugin-pnp): add 'pnpm' option in nodeLinker config description (…
926c4b2 
…#5850)

**What's the problem this PR addresses?**

Fixes: #5847

**How did you fix it?**

Add 'pnpm' option in nodeLinker config description

**Checklist**
- [x] I have read the [Contributing
Guide](https://yarnpkg.com/advanced/contributing).
- [x] I have set the packages that need to be released for my changes to
be effective.
- [x] I will check that all automated PR checks pass before the PR gets
reviewed.

---------

Co-authored-by: Kristoffer K. <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@arcanis @trivikr