fixing bug with New function #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulbramsen
approved these changes
Jun 7, 2024
|
LGTM! |
|
@yawn can you approve the workflow, merge, and release this in a 1.0.6 fix? |
|
Yeah, sorry for being unresponsive. @akerl took over as the primary maintainer due to my time being in short supply - I'll need to check what they did in terms of workflow and how they are releasing this nowadays. If I'm luck I can do this right now. |
|
Fixed CI issue in 08ac73f, merging. |
|
All done. Thanks @ryandeivert and @paulbramsen! Ping @akerl for visibility. |
|
<3 thanks for the merge, @yawn, and sorry for introducing the regression |
|
thanks everyone! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to @yawn
cc @paulbramsen
Background
The
ykoath.New()function is intended to return the first yubikey, but in v1.0.5 a bug was introduced that breaks this:Changes
The
NewFromSerialListchecks to see a array of any serials was provided, and is intended to return the first yubikey in the event that no serials are provided. However, that fails because theNew()function always sends an empty string ("") as the serial.This change calls the
NewFromSerialListwith an empty array, ensuring the first yubikey entry is returned to the caller.This reverts the back to what existed in <v1.0.4.