From 3b73ae83cc54c5b343a28bf4cf35175030615810 Mon Sep 17 00:00:00 2001 From: ya-ksgamora Date: Thu, 30 Jan 2025 13:12:19 +0000 Subject: [PATCH] [NBS] Increase logging verbosity: include group ID in (Read|Write)Blob logs --- .../blockstore/libs/storage/partition/part_actor_readblob.cpp | 3 ++- .../blockstore/libs/storage/partition/part_actor_writeblob.cpp | 3 ++- .../libs/storage/partition2/part2_actor_readblob.cpp | 3 ++- .../libs/storage/partition2/part2_actor_writeblob.cpp | 3 ++- 4 files changed, 8 insertions(+), 4 deletions(-) diff --git a/cloud/blockstore/libs/storage/partition/part_actor_readblob.cpp b/cloud/blockstore/libs/storage/partition/part_actor_readblob.cpp index fd2bdbc7910..f5e70a443bd 100644 --- a/cloud/blockstore/libs/storage/partition/part_actor_readblob.cpp +++ b/cloud/blockstore/libs/storage/partition/part_actor_readblob.cpp @@ -107,8 +107,9 @@ void TPartitionActor::HandleReadBlobCompleted( >= Config->GetMaxReadBlobErrorsBeforeSuicide()) { LOG_WARN(ctx, TBlockStoreComponents::PARTITION, - "[%lu] Stop tablet because of too many ReadBlob errors: %s", + "[t:%lu] [g:%u] Stop tablet because of too many ReadBlob errors: %s", TabletID(), + msg->GroupId, FormatError(msg->GetError()).data()); ReportTabletBSFailure(); diff --git a/cloud/blockstore/libs/storage/partition/part_actor_writeblob.cpp b/cloud/blockstore/libs/storage/partition/part_actor_writeblob.cpp index 40c1b6224b3..d0093e26fed 100644 --- a/cloud/blockstore/libs/storage/partition/part_actor_writeblob.cpp +++ b/cloud/blockstore/libs/storage/partition/part_actor_writeblob.cpp @@ -429,8 +429,9 @@ void TPartitionActor::HandleWriteBlobCompleted( if (FAILED(msg->GetStatus())) { LOG_WARN(ctx, TBlockStoreComponents::PARTITION, - "[%lu] Stop tablet because of WriteBlob error: %s", + "[t:%lu] [g:%u] Stop tablet because of WriteBlob error: %s", TabletID(), + groupId, FormatError(msg->GetError()).data()); ReportTabletBSFailure(); diff --git a/cloud/blockstore/libs/storage/partition2/part2_actor_readblob.cpp b/cloud/blockstore/libs/storage/partition2/part2_actor_readblob.cpp index 4516d58748e..a16e6c7b6de 100644 --- a/cloud/blockstore/libs/storage/partition2/part2_actor_readblob.cpp +++ b/cloud/blockstore/libs/storage/partition2/part2_actor_readblob.cpp @@ -429,8 +429,9 @@ void TPartitionActor::HandleReadBlobCompleted( >= Config->GetMaxReadBlobErrorsBeforeSuicide()) { LOG_WARN(ctx, TBlockStoreComponents::PARTITION, - "[%lu] Stop tablet because of too many ReadBlob errors: %s", + "[t:%lu] [g:%u] Stop tablet because of too many ReadBlob errors: %s", TabletID(), + msg->GroupId, FormatError(msg->GetError()).data()); ReportTabletBSFailure(); diff --git a/cloud/blockstore/libs/storage/partition2/part2_actor_writeblob.cpp b/cloud/blockstore/libs/storage/partition2/part2_actor_writeblob.cpp index 27a71bec5d6..4b745806511 100644 --- a/cloud/blockstore/libs/storage/partition2/part2_actor_writeblob.cpp +++ b/cloud/blockstore/libs/storage/partition2/part2_actor_writeblob.cpp @@ -359,8 +359,9 @@ void TPartitionActor::HandleWriteBlobCompleted( if (FAILED(msg->GetStatus())) { LOG_WARN(ctx, TBlockStoreComponents::PARTITION, - "[%lu] Stop tablet because of WriteBlob error: %s", + "[t:%lu] [g:%u] Stop tablet because of WriteBlob error: %s", TabletID(), + group, FormatError(msg->GetError()).data()); ReportTabletBSFailure();